Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: replace "Fixup ready" with "Apply Edits" button #1201

Merged
merged 3 commits into from
Sep 28, 2023
Merged

change: replace "Fixup ready" with "Apply Edits" button #1201

merged 3 commits into from
Sep 28, 2023

Conversation

toolmantim
Copy link
Contributor

Replace the "Fixup ready | Apply" buttons when you do a code edit with a single "Apply Edits" button.

Before After
Screenshot 2023-09-27 at 9 27 52 pm Screenshot 2023-09-27 at 9 31 09 pm

Test plan

  • Ran Edit Code
  • Reviewed buttons
  • Clicked buttons

@toolmantim toolmantim requested review from a team and removed request for a team September 28, 2023 01:41
@toolmantim toolmantim enabled auto-merge (squash) September 28, 2023 01:53
@toolmantim toolmantim merged commit e603250 into main Sep 28, 2023
11 checks passed
@toolmantim toolmantim deleted the tl/reword-edit-codelenses branch September 28, 2023 01:56
@abeatrix
Copy link
Contributor

Niceeeee

@chenkc805
Copy link

LGTM

chenkc805
chenkc805 reviewed Sep 28, 2023
View reviewed changes
Copy link

@chenkc805 chenkc805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenkc805 chenkc805 chenkc805 left review comments

@valerybugakov valerybugakov valerybugakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@toolmantim @abeatrix @chenkc805 @valerybugakov