Autocomplete: Don't trigger on closing characters #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
changed the title
abeatrix
approved these changes
Sep 28, 2023
| @@ -183,6 +183,11 @@ async function doGetInlineCompletions(params: InlineCompletionsParams): Promise< | |||
| return null | |||
| } | |||
|
|
|||
| // Do not trigger when the last character is a closing symbol | |||
| if (triggerKind !== TriggerKind.Manual && /[)\]}]$/.test(docContext.prefix.trim())) { | |||
There was a problem hiding this comment.
What if I'm in the middle of a function body and expect a single-line completion?
function whatever() {
const data = {
value: true
}
█
}There are multiple similar cases where I would like to see completions being generated. WDYT?
There was a problem hiding this comment.
Fair, let's not look at the prefix but the sameLinePrefix instead
There was a problem hiding this comment.
I think looking at the current line only is a closer approximation to the cursor: "}" metric we were seeing anyways. I think right now this triggers pretty often because inserting a completion will trigger a new completion request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
Test added