Detect more test files #1297
Merged
Detect more test files #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
commented
Oct 3, 2023
lib/shared/src/chat/prompts/utils.ts
Outdated
Comment on lines
227
to
233
| return ( | ||
| fileNameWithoutExt.startsWith('test') || | ||
| fileNameWithoutExt.endsWith('test') || | ||
| fileNameWithoutExt.endsWith('tests') || | ||
| fileNameWithoutExt.endsWith('spec') | ||
| ) | ||
| } |
There was a problem hiding this comment.
I think I will change this to a regex to avoid things like Protest :D
abeatrix
approved these changes
Oct 3, 2023
philipp-spiess
commented
Oct 3, 2023
Comment on lines
+45
to
+46
| ['/path/to/testFile.java', false], | ||
| ['/path/to/testFile.js', false], |
There was a problem hiding this comment.
These two I broke in this PR since it doesn't seem to be from a popular test framework, but maybe I am overlooking something?
There was a problem hiding this comment.
They were not! I wasn't doing any lang-specified lookup so anything that starts with test would have passed lol thanks for updating this
valerybugakov
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I asked GPT4 to give me some common examples and made the test pass. WDYT @abeatrix?
Test plan
Test green