refactor: split min latency flags #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiccooney
requested changes
Oct 10, 2023
Co-authored-by: Philipp Spiess <hello@philippspiess.com> Co-authored-by: Dominic Cooney <dominic.cooney@sourcegraph.com>
|
@dominiccooney @philipp-spiess thanks for taking the time to review the PR. I've made the changes based on your valuable input,added a new feature flag for provider based, and made sure they all work independently. |
dominiccooney
approved these changes
Oct 11, 2023
Co-authored-by: Dominic Cooney <dominic.cooney@sourcegraph.com>
abeatrix
added a commit
that referenced
this pull request
Oct 16, 2023
RE: #1351 fix: apply min latency only when last suggestion was read The minimum latency for code suggestions is now only applied when the last suggestion was read by the user. This avoids applying the latency when the user is actively typing and has not read the previous suggestions. The lastCompletionRequestTimestamp property tracks when the last suggestion request was made. The latency is skipped if the time since last request is less than 750ms. ## Test plan <!-- Required. See https://docs.sourcegraph.com/dev/background-information/testing_principles. --> Check the output channel. You should not see latency getting increased after 5 keystrokes, which is the current behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: https://sourcegraph.slack.com/archives/C05AGQYD528/p1696845420506809
refactor: replace cody autocomplete minimum latency flag with user, provider, and language based latency flags
Replaced the
CodyAutocompleteMinimumLatencyfeature flag with two new flags:CodyAutocompleteUserLatency: Enables minimum latency for Cody autocomplete. Works the same as the oldCodyAutocompleteMinimumLatencyflag but rename it to make sure the old flag will not be used in older versions.CodyAutocompleteLanguageLatency: Enables language-specific minimum latency for Cody autocomplete for low-performance languages ONLYCodyAutocompleteProviderLatency: Enables provider-specific minimum latency for non-anthropic providerExpected behavior:
CodyAutocompleteUserLatencyis enabledCodyAutocompleteLanguageLatencyis enabledCodyAutocompleteProviderLatencyis enabledThe getLatency function now accepts feature flags and calculates latency accordingly.
This allows more granular control over autocomplete latency based on user, provider, and language.
Test plan
Unit tests are updated.