VScode: Add popups for all embeddings conditions #1374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dotcom/App users can always click on the chat input status indicator and see the state of embeddings in a popup.
Caveats/limitations:
Part of #632
Test plan
This does not add automated tests yet. That is in a follow-up change, I need to update the existing tests to use simplified onboarding first.
UI check:
pnpm storybook
and examine the App-less Onboarding stories.Manual tests:
A directory that's not a git repository:
Open
main.c
, open Cody, click on the chat input status indicator:A git repository that does not have a remote:
Cmd-Shift-P, Reload Window (we do not watch for repos changing status in this way.) Chat status indicator should be as above.
A git repository with a remote:
Ensure App is not running.
Cmd-Shift-P, Reload Window (we do not watch for repos changing status in this way.) Chat status indicator:
A git repository that is indexed with app:
Install app if it is not installed. Click Open App and go through the repository indexing flow. If there are existing repositories click Add a repository.
You can force repo indexing by right clicking on App UI, Inspect Element,
window.location = '/api/console'
in the Console, and run this GraphQL mutation:Note there is no .git on the repo name. Check that there is a job with state "COMPLETED":
In VScode, open popup and click Reload, status indicator:
git repository indexed by dotcom:
In VScode, File, Open Folder,
/tmp/react
and trust the authors. Chat input status:Repeat the above looking at different themes.