Autocomplete: Track inserted completions #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arafatkatze
reviewed
Oct 12, 2023
arafatkatze
reviewed
Oct 13, 2023
valerybugakov
approved these changes
Oct 17, 2023
Comment on lines
+19
to
+20
| // When a document is rename, the TextDocument instance will still work | ||
| // however the URI it resolves to will be outdated. Ensure we never use it. |
| logCompletionEvent('persistence:present', { | ||
| id: trackedCompletion.id, | ||
| afterSec: MEASURE_TIMEOUTS[measureTimeoutsIndex] / 1000, | ||
| isMostlyUnchanged, |
There was a problem hiding this comment.
Do we need to log this flag? Might as well use the difference field we already have and define the isMostlyUnchanged value in the analytics dashboard.
There was a problem hiding this comment.
| const initialText = trackedCompletion.completion.insertText | ||
| const latestText = trackedCompletion.document.getText(trackedCompletion.latestRange) | ||
|
|
||
| if (latestText.length === 0) { |
There was a problem hiding this comment.
Not sure if it's possible, but we might want to filter out items where initialText.length === 0 too
Comment on lines
48
to
49
| return levenshtein(A, B) | ||
| } |
There was a problem hiding this comment.
Should we remove this helper (LevenshteinCompare) altogether because it doesn't add value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tracking for inserted completion after 30 seconds, 2 minutes, 5 minutes, 10 minutes.
This also replaces our levenshtein comparator since I found a bug in the current implementation (see the added test case for more context).
Test plan