Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not open chat for doc/edit commands #1678

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented Nov 8, 2023

Reported in https://sourcegraph.slack.com/archives/C05AGQYD528/p1699400897961909

fix: do not open chat for doc/edit commands

The /doc and /edit commands were incorrectly opening a new chat panel. This fixes it to not creating any new chat panel or opening existing chat window when running the /doc and /edit commands.

Demo

Screen.Recording.2023-11-07.at.7.08.35.PM.mov

Test plan

First, close the cody sidebar

Then try running the /doc command from:

  • chat
  • command palette
  • right click context menu

before

An empty chat window will pop up

after

All chat windows remains closed (when closed)

@abeatrix abeatrix requested a review from a team November 8, 2023 03:21
@abeatrix abeatrix merged commit 075c794 into main Nov 8, 2023
13 checks passed
@abeatrix abeatrix deleted the bee/fix-doc-command branch November 8, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants