fix: handle keyboard shortcuts with Ctrl key #1690
Merged
+12
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: prevent default and stop propagation on certain key combos
Prevent default behavior on
ctrl + non-allowlisted keys
..Also check for alt + vscode cody shortcuts and prevent default without stopping propagation.
This fixes issues with certain key combinations triggering unintended characters in input box.
Test plan
Pressing CtrlKey with any of the keys in the allowed list should not add character to the chat inbox.
Before
Press
alt
+/
when chat box is focused. This shortcut will open a new Cody panel, but it will also add a symbol to your chat input box:After
Press
alt
+/
when chat box is focused will not change your current input in the input box.