Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error from new chat shortcut #1696

Merged
merged 2 commits into from
Nov 9, 2023
Merged

fix: error from new chat shortcut #1696

merged 2 commits into from
Nov 9, 2023

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented Nov 9, 2023

fix: prevent "command not found" error when chat panel disabled

Update the keybinding enablement conditions to avoid invoking the command when the chat panel config is disabled. This fixes the "command not found" error that currently shows when invoking the keybinding while cody.experimental.chatPanel is false.

Test plan

Before

In the old chat UI, focus on the chat input box, and then press alt + / - you will see an error message pops up:

image

After

Do the same thing as described above - you should not see the error message pop up again.

@abeatrix abeatrix requested a review from a team November 9, 2023 00:04
@abeatrix abeatrix merged commit 9e48dce into main Nov 9, 2023
12 of 13 checks passed
@abeatrix abeatrix deleted the bee/fix-panels-error branch November 9, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants