Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up login page styles #1708

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Clean up login page styles #1708

merged 6 commits into from
Nov 14, 2023

Conversation

toolmantim
Copy link
Contributor

  • Moves the Enterprise sign in link up under the social login links
  • Makes the button logos monochrome
  • Updates the window sizing and button width behaviour to match standard VS Code behaviour
Before After
Screenshot 2023-11-10 at 2 37 12 pm Screenshot 2023-11-10 at 2 36 59 pm

Test plan

  • Loaded extension
  • Previewed widths and clicked buttons

@toolmantim
Copy link
Contributor Author

@dominiccooney I also tried fixing the "Sourcegraph.com" that erroneously appears in the "Recent" list when you click "Sign In To Enterprise Instance" but failed (I think perhaps its coming from https://github.com/sourcegraph/cody/blob/main/vscode/src/services/AuthProvider.ts#L377)

Copy link
Contributor

@dominiccooney dominiccooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monochrome sign in logos look great!

@dominiccooney
Copy link
Contributor

I also tried fixing the "Sourcegraph.com" that erroneously appears in the "Recent" list when you click "Sign In To Enterprise Instance"

I wrote that FIXME and it is apt, the code is racy. We should add a state machine here so we don't mix state from one sign in to another. Once we remove App it gets a bit simpler and we can lean into that to fix these.

@toolmantim toolmantim enabled auto-merge (squash) November 14, 2023 11:02
@toolmantim toolmantim merged commit f3aab51 into main Nov 14, 2023
14 checks passed
@toolmantim toolmantim deleted the tl/login-style-improvements branch November 14, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants