Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup chat model selector styles #1750

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Conversation

toolmantim
Copy link
Contributor

This cleans up the chat model selector styles so it now has a keyboard focus outline, fixes some bugs with changing model with the keyboard, more closely matches VS Code styles (the webui toolkit is out of date), leaves space on the right for other buttons in the future (e.g. raw view), and includes the chat provider icon at the top of the chat.

Before After
Screenshot 2023-11-15 at 5 56 46 pm Screenshot 2023-11-15 at 5 55 27 pm

Test plan

  • Start a new chat, select items
  • Open an existing chat, verify disabled state

@toolmantim
Copy link
Contributor Author

@abeatrix I wanted to also focus the chat input whenever you choose a new model, but I couldn't figure out how to do that. Any tips?

@toolmantim toolmantim requested a review from a team November 15, 2023 08:52
@abeatrix
Copy link
Contributor

I wanted to also focus the chat input whenever you choose a new model, but I couldn't figure out how to do that. Any tips?

pushed some changes for this. Feel free to revert it if it doesn't work the way you want

@toolmantim
Copy link
Contributor Author

That is perfect @abeatrix! Thank you!

@toolmantim toolmantim requested review from abeatrix and removed request for abeatrix November 15, 2023 22:55
@toolmantim toolmantim enabled auto-merge (squash) November 15, 2023 22:58
@toolmantim toolmantim merged commit f7529bc into main Nov 15, 2023
13 checks passed
@toolmantim toolmantim deleted the tl/cleanup-model-selector branch November 15, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants