Autocomplete: Prepare mixed retrieval examples #1752
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new context retrieval strategies that relies on mixing existing retrievers and changes how LSP light works:
bfg-mixed
is a new setup that combines BFG retrieval and mixes it with the local jaccard similarity based scoring. This makes bfg more of an addition on top of local context rather then an alternative and should help for cases where BFG doesn't retrieve the best results yet. We can control it with an individual feature flag too.local-mixed
is a new setup that combines jaccard similiarty results with the section history retriever I added. I still think that there's something magical about just knowing which function you last changed and with this flag I want to find out if that's trueAdditionally this changes
lsp-light
to mix with jaccard similiarty and not the section history only. We know that jaccard performs well and mixing with it should not make the result much worse (that would happen if we remove it)Test plan
bfg mixed
local mixed