Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: Prepare mixed retrieval examples #1752

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

philipp-spiess
Copy link
Contributor

This PR adds two new context retrieval strategies that relies on mixing existing retrievers and changes how LSP light works:

  1. bfg-mixed is a new setup that combines BFG retrieval and mixes it with the local jaccard similarity based scoring. This makes bfg more of an addition on top of local context rather then an alternative and should help for cases where BFG doesn't retrieve the best results yet. We can control it with an individual feature flag too.
  2. local-mixed is a new setup that combines jaccard similiarty results with the section history retriever I added. I still think that there's something magical about just knowing which function you last changed and with this flag I want to find out if that's true

Additionally this changes lsp-light to mix with jaccard similiarty and not the section history only. We know that jaccard performs well and mixing with it should not make the result much worse (that would happen if we remove it)

Test plan

bfg mixed

Screenshot 2023-11-15 at 12 10 46

local mixed

Screenshot 2023-11-15 at 12 14 25

@philipp-spiess philipp-spiess requested a review from a team November 15, 2023 11:21
@philipp-spiess philipp-spiess self-assigned this Nov 15, 2023
@philipp-spiess philipp-spiess requested review from a team and removed request for a team November 15, 2023 11:21
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!

@philipp-spiess philipp-spiess enabled auto-merge (squash) November 15, 2023 15:33
@philipp-spiess philipp-spiess merged commit c921595 into main Nov 15, 2023
13 checks passed
@philipp-spiess philipp-spiess deleted the ps/ac-new-mixer branch November 15, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants