change: replace vscode links with command #1919
Conversation
| const filteredFsPath = range ? fsPath.slice(0, rangeIndex) : fsPath | ||
| const uri = vscode.Uri.file(filteredFsPath) | ||
| const doc = await vscode.workspace.openTextDocument(uri) | ||
| const viewColumn = vscode.ViewColumn.Beside - 2 > 1 ? vscode.ViewColumn.Beside - 2 : vscode.ViewColumn.Beside |
There was a problem hiding this comment.
I don't quite understand this line… but based on the video I think we should just let it open in a tab in the active group (which is what it did before by default, and same as what the file explorer does by default).
File explorer lets you command-click to open a file in a new tab group, how about we support that instead? (not required for this PR though)
There was a problem hiding this comment.
i've updated to open it in the current active editor instead:
Screen.Recording.2023-11-27.at.9.48.48.PM.mov
File explorer lets you command-click to open a file in a new tab group, how about we support that instead? (not required for this PR though)
I can't reproduce this behavior using the built-in vscode.open command, so we can file a feature request for this to work on after GA if that sounds good to you?
CLOSE: #1819
This PR replace the vscode links with custom protocol for the file links in chat view.
Test plan
Run the /explain command, and then click on the link after the @ sign:
Screen.Recording.2023-11-27.at.9.00.04.PM.mov