Edit: Use a tracked originalRange when retrying a task
#1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umpox
changed the title
umpox
changed the title
originalRange when retrying a task
umpox
force-pushed
the
tr/retry-range
branch
from
b7cb7e4
to
0bd29b6
Compare
beyang
approved these changes
Nov 28, 2023
| * Only handles edits that are outside of the range, as it is purely focused on shifting a fixed range in a document. | ||
| * Does not expand or shrink the original rank. | ||
| */ | ||
| export function updateFixedRange(range: vscode.Range, change: TextChange): vscode.Range { |
There was a problem hiding this comment.
Seems like a good candidate for a unit test.
There was a problem hiding this comment.
Agree, have added a test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RetryLogic.mov
Follow up on: #1892 (comment)
We were retrying fixup tasks with the
selectionRange- this is not suitable as this range may shrink or expand depending on the code that the LLM produces.Instead we should use the
originalRange- the range that is provided when the fixup task is created. We still need to track the positions of the range, as it could shift due to code being added above.Test plan