Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Restart Chat Session" icon and add a confirmation #2002

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

toolmantim
Copy link
Contributor

This changes the current icon from reload (which is too close to a browser reload) to clear-all (which isn't perfect but looks more destructive). It also adds a confirmation dialog:

Before After
Screenshot 2023-11-30 at 4 09 59 pm Screenshot 2023-11-30 at 4 10 24 pm
Confirmation
Screenshot 2023-11-30 at 4 03 17 pm

Test plan

  • Viewed the button
  • Clicked the button, verify prompt cancel does nothing
  • Clicked the button, verify "Restart Chat Session" does the action
  • Typed /reset and verify it doesn't ask for confirmation

@toolmantim toolmantim requested a review from a team November 30, 2023 05:13
@toolmantim toolmantim merged commit d06986e into main Nov 30, 2023
13 checks passed
@toolmantim toolmantim deleted the tl/change-reset-chat-icon branch November 30, 2023 10:50
@abeatrix
Copy link
Contributor

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants