Edit: Only affix non-whitespace changes to ranges #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valerybugakov
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to allow affixing non-whitespace characters and including that in the edit selection range (e.g.
exportbefore a function, or a JSDoc above an identifier).We do not want to affix whitespace characters, as this may be from the user moving their cursor onto a different line, or repositioning the code.
Before
RangeBefore.mov
After
RangeAfter.mov
Test plan
Create fixup
Move cursor to start of range
Enter non-whitespace characters and see range expands
Create fixup
Move cursor to start of range
Enter whitespace characters and see range does not expand