change: enable new chat and search UIs by default #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeatrix
commented
Dec 4, 2023
Closed
philipp-spiess
approved these changes
Dec 5, 2023
Yea they were turned off by default and confirmed with product here to remove inline chat here: https://sourcegraph.slack.com/archives/C066F85TE80/p1701709918296539?thread_ts=1701709448.915889&channel=C066F85TE80&message_ts=1701709918.296539 |
kalanchan
reviewed
Dec 5, 2023
kalanchan
approved these changes
Dec 5, 2023
This was referenced Dec 12, 2023
philipp-spiess
added a commit
that referenced
this pull request
Dec 12, 2023
Fixes #2292 Previously, detecting pastes into the document required the inline chat controller to be listening for changes. Since that was removed in #2079, we no longer detected pasts. This brings this behavior back via a dedicated event listener we add in `main`. ## Test plan - Ask cody to gen code - Copy it - Paste it into a doc <img width="1132" alt="Screenshot 2023-12-12 at 11 22 37" src="https://github.com/sourcegraph/cody/assets/458591/d3c14317-b7ad-4270-a41f-30448781d149"> <!-- Required. See https://docs.sourcegraph.com/dev/background-information/testing_principles. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTEXT: https://sourcegraph.slack.com/archives/C066F85TE80/p1701709448915889
change: enable new chat and search UIs by default
experimentalChatPanelandexperimentalSearchPanelconfiguration options.Follow up
Cean up chat manager and sidebar chat view.
Test plan
All the tests have been updated to run on the new chat UI instead.