Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat: Close the Enhanced Context popover on chat input focus #2091

Merged
merged 8 commits into from
Dec 5, 2023

Conversation

toolmantim
Copy link
Contributor

Updates the Enhanced Context popover so it closes when the chat message input is focused, removing an extra click.

Before:

Screen.Recording.2023-12-05.at.1.48.18.pm.mov

After:

Screen.Recording.2023-12-05.at.1.49.03.pm.mov

Test plan

  • Start a new chat
  • Click the enhanced context button
  • Click the text input
  • Click the enhanced context button again
  • Click close button

@toolmantim toolmantim requested review from dominiccooney and a team December 5, 2023 02:54
@toolmantim toolmantim added this to the dec/chat-ux-improvements milestone Dec 5, 2023
Copy link
Contributor

@dominiccooney dominiccooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid.

@toolmantim toolmantim enabled auto-merge (squash) December 5, 2023 06:26
@toolmantim toolmantim merged commit f854006 into main Dec 5, 2023
14 checks passed
@toolmantim toolmantim deleted the tl/close-enhanced-context-on-chat-input-focus branch December 5, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants