fix: decrease chat panel creation debounce time #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
approved these changes
Dec 5, 2023
toolmantim
added a commit
that referenced
this pull request
Dec 6, 2023
) Follow up to #2115, this ensures we trigger chat panel creation and restoration straight away (on the leading edge of the timeout), and reduces the restoration timeout to match. ## Test plan - Open new chat - Open existing chat - Reload window and ensure restores correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debounce time for creating new chat panels was decreased from 1000ms to 250ms. This should make the chat panels feel more responsive when opening multiple in quick succession.
We previously defaulted it to 1000ms because of some start-up issues that caused loading issues on panel creation time, but recent improvement allows us to lower this debouce time.
Test plan
Try opening multiple windows to confirm the windows can still be started up successfully.
Screen.Recording.2023-12-05.at.9.56.13.PM.mov