VSCode: Do not parse Windows file paths as URIs #2197
Merged
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2184.
Uri.parse
parses URIs,Uri.file
takes a file path and turns it into a URI. For UNIX-style paths,Uri.parse
works fine, but for Windows file paths, parsing them as URIs is wrong; the the drive separator is URL-encoded and the URI is unusable, etc.Extension.Development.Host.CODE_OF_CONDUCT.md.-.lexical.-.Visual.Studio.Code.2023-12-08.11-59-54.mp4
Test plan