Don't duplicate @-filenames when pressing tab if the whole string has been typed #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was using
input.lastIndexOf(fileDisplayText)to find the location of the text to compute the suffix, but it didn't take into account the length, so any time input contained fileDisplayText, the contents of fileDisplayText would become duplicated.(@abeatrix the original code was added as part of a fix for #1973 - in my testing that still seems to work correctly with my change, but let me know if I've misunderstood).
Fixes #2200
Test plan
pnpm test:unit at-fileor<tab>to accept the file