-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCode: Make embeddings errors visible, resume indexing on restart #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiccooney
force-pushed
the
dpc/local-embeddings-protocol-updates
branch
from
December 12, 2023 14:15
13b264b
to
2183ccd
Compare
dominiccooney
changed the title
Local embeddings protocol updates
VSCode: Make embeddings errors visible, resume indexing on restart
Dec 12, 2023
dominiccooney
force-pushed
the
dpc/local-embeddings-protocol-updates
branch
from
December 13, 2023 00:38
5ab1159
to
d1c2de4
Compare
toolmantim
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems legit & doesn't break setting up new embeddings. I did not manually test the incomplete embeddings scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/242be2c7abcd49d19e1709e0529651b1
UX refresh: https://www.loom.com/share/2654feb99c9f4985add94470a362bec7
Test plan
Manual test:
To generate an unusual failure mode, edit another git repo's remote to match the partial index and open that folder. Then resume indexing. This should display an error message about the repo not having the specific commit the index was created at. (This resumes an incomplete index, it does not update an index to a new commit.)
Automated test:
pnpm test:e2e -- local-embeddings.test.ts