Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rate limit number being displayed #2312

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Fix rate limit number being displayed #2312

merged 3 commits into from
Dec 12, 2023

Conversation

philipp-spiess
Copy link
Contributor

We were calling [0] even though it was a string which lead to it picking the first character. So if the rate limit was 222 it would show up as 2

Test plan

Screenshot 2023-12-12 at 22 06 57
  • Log in with rate limited David user
  • Send a message

@philipp-spiess philipp-spiess requested review from rafax and a team December 12, 2023 21:08
vscode/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Rafał Gajdulewicz <rafax@users.noreply.github.com>
@philipp-spiess philipp-spiess enabled auto-merge (squash) December 12, 2023 21:18
@philipp-spiess philipp-spiess merged commit 7153175 into main Dec 12, 2023
13 checks passed
@philipp-spiess philipp-spiess deleted the ps/fix-limit branch December 12, 2023 21:20
@toolmantim
Copy link
Contributor

Nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants