Chat: Fix chat panel titles #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making this PR, Tom. I just made a push to my branch, and was trying to create a PR but saw it is fixed :) This was a very small fix, but took some time for me to debug, haha! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #2260
Fixes the title of reopened chat panels.
We were using the
chatIdby accident before, due to a mistake when calling this functionNote
We could just not pass the
chatIdbut we have two implementations of the ChatPanelProvider right now. One relies on thechatIdand one doesn't. Will start a thread on Slack to discuss this as it can be quite confusing to debug!Before
After
Test plan