Autocomplete: Do not trigger a completion if a single-line completion was accepted #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiccooney
approved these changes
Dec 21, 2023
vscode/src/completions/get-inline-completions-tests/no-request-when-accepting.test.ts
Outdated
Show resolved
Hide resolved
| } | ||
| ) | ||
| ) | ||
| ).not.toEqual<V>(null) |
| // Thus, this results in a request that almost always has zero results but still incurs network | ||
| // and inference costs. | ||
| it('should not make a request after accepting a completion', async () => { | ||
| const initialRequestParams = params( |
There was a problem hiding this comment.
This test and the next one would be more readable if they used a helper function that's parameterized on the trigger kind to show that, exact same situation with implicit trigger doesn't cause a follow on completion attempt, but manual trigger does.
The difference in trigger kind is only one line, it is hard to spot it in the midst of the rest of the test code.
There was a problem hiding this comment.
muuuch better 🙇
…-when-accepting.test.ts Co-authored-by: Dominic Cooney <dominic.cooney@sourcegraph.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small optimization that should cut down a bit on unnecessary LLM request:
In VS Code, if you accept a completion, this changes the document and thus issue a new completion request. Makes sense! The thing is: we always complete full lines so the chance that you do want a follow-up completion is very slim. In some cases the ending
)or;helps to guard against this but not in all cases.This PR adds a special logic now to detect this case and not issue a completion (so accepting a completion via
tabwon't issue a new request but any further keystroke (likeenter) will).Test plan
Screen.Recording.2023-12-20.at.15.33.07.mov