Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove command inline mode #2551

Merged
merged 2 commits into from
Jan 3, 2024
Merged

refactor: remove command inline mode #2551

merged 2 commits into from
Jan 3, 2024

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented Jan 3, 2024

Demo

Screen.Recording.2024-01-03.at.7.57.41.AM.mov

Test plan

  1. Run the doc command, only CodyVSCodeExtension:command:doc:executed should be logged without CodyVSCodeExtension:command:edit:executed

Log for example:

█ logEvent (telemetry disabled): CodyVSCodeExtension:command:doc:executed VSCode {"properties":{"source":"doc"},"opts":{"hasV2Event":true}}
█ telemetry-v2: recordEvent (no-op): cody.command.doc/executed: {"parameters":{"version":0,"privateMetadata":{"source":"doc"}},"timestamp":"2024-01-03T15:57:44.677Z"}
█ logEvent (telemetry disabled): CodyVSCodeExtension:recipe:fixup:executed VSCode {"properties":{"contextSummary":{"embeddings":0,"local":2,"user":0},"source":"doc"}
  1. Run the edit command, CodyVSCodeExtension:command:edit:executed should be logged once

Log for example:

█ logEvent (telemetry disabled): CodyVSCodeExtension:command:edit:executed VSCode {"properties":{"source":"editor"},"opts":{"hasV2Event":true}}
█ telemetry-v2: recordEvent (no-op): cody.command.edit/executed: {"parameters":{"version":0,"privateMetadata":{"source":"editor"}},"timestamp":"2024-01-03T16:00:24.386Z"}
█ logEvent (telemetry disabled): CodyVSCodeExtension:recipe:fixup:executed VSCode {"properties":{"contextSummary":{"embeddings":1,"local":2,"user":0},"source":"editor","requestID":"c374e01f-4182-4fa9-b5c2-760c6b260857"}

@abeatrix abeatrix marked this pull request as ready for review January 3, 2024 16:02
@abeatrix abeatrix requested review from umpox and a team January 3, 2024 16:02
Copy link
Contributor

@umpox umpox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@abeatrix abeatrix merged commit a12a1fd into main Jan 3, 2024
14 checks passed
@abeatrix abeatrix deleted the bee/remove-inline-mode branch January 3, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: User-invoked commands are not firing events in a 1:1 manner
2 participants