Cleanup test code and add tests for rate limits #2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
reviewed
Jan 8, 2024
agent/src/index.test.ts
Outdated
| public accessToken?: string | ||
| public info: ClientInfo | ||
|
|
||
| constructor(name: string, accessToken?: string) { |
There was a problem hiding this comment.
FYI, you can use public/private readonly to avoid declaring separate properties. Similar to case classes
Suggested change
| constructor(name: string, accessToken?: string) { | |
| constructor(public readonly name: string, public readonly accessToken?: string) { |
olafurpg
reviewed
Jan 8, 2024
| @@ -103,7 +103,9 @@ recordings. | |||
| To fix this problem, update the HTTP recordings with the following command: | |||
|
|
|||
| ```sh | |||
| export SRC_ACCESS_TOKEN=sgp_YOUR_ACCESS_TOKEN # redacted in the recordings | |||
| # tokens are redacted in the recordings | |||
| export SRC_ACCESS_TOKEN_WITH_RATE_LIMIT=sgp_YOUR_ACCESS_TOKEN_WITH_RATE_LIMIT | |||
There was a problem hiding this comment.
Link to this message to find the token https://sourcegraph.slack.com/archives/C059N5FRYG3/p1702990080820699
pkukielka
force-pushed
the
pkukielka/improve-agent-tests
branch
from
889cd28
to
5565c36
Compare
olafurpg
reviewed
Jan 8, 2024
| super() | ||
|
|
||
| this.name = name |
olafurpg
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
No needed, those are just changes for the tests.
Changes: