Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Enterprise login button more prominent #2672

Merged
merged 6 commits into from
Jan 11, 2024
Merged

Make the Enterprise login button more prominent #2672

merged 6 commits into from
Jan 11, 2024

Conversation

toolmantim
Copy link
Contributor

@toolmantim toolmantim commented Jan 11, 2024 •
edited

Updates to the login styles as per Google Doc.

Before After
Screenshot 2024-01-11 at 2 17 54 pm Screenshot 2024-01-11 at 3 11 26 pm

Notes:

  • The secondary button color across VS Code themes often made it more prominent than the primary (the opposite of what we want), so the Enterprise login button was changed to be the same primary color as the others

Test plan

  • Viewed the login page
  • Clicked the Enterprise login button
  • Clicked the learn more link

@toolmantim toolmantim requested a review from a team January 11, 2024 03:19
abeatrix
abeatrix approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ♥️

dominiccooney
dominiccooney approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@dominiccooney dominiccooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always a delight to see correct use of  .

sqs
sqs approved these changes Jan 11, 2024
View reviewed changes
vscode/webviews/OnboardingExperiment.tsx Outdated Show resolved Hide resolved
@toolmantim toolmantim merged commit a28c29d into main Jan 11, 2024
15 checks passed
@toolmantim toolmantim deleted the tl/bigger-enterprise-login-buttons branch January 11, 2024 04:32
@rrhyne
Copy link
Contributor

rrhyne commented Jan 11, 2024

Thanks Tim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqs sqs sqs approved these changes

@dominiccooney dominiccooney dominiccooney approved these changes

@abeatrix abeatrix abeatrix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@toolmantim @rrhyne @sqs @dominiccooney @abeatrix