Autocomplete: insert missing brackets before completion truncation #2682

valerybugakov · 2024-01-11T10:20:14Z

Context

Improves the stability of multiline completion truncation during streaming by gracefully handling missing brackets in incomplete code segments.
Closes bug: multiline completions are truncated too early if the parse tree is broken because of the missing brackets #2387

Added new unit tests.

philipp-spiess

The code makes sense but I think the integration test would not happen as such in the real world.

vscode/src/completions/get-inline-completions-tests/multiline-truncation.test.ts

Autocomplete: insert missing brackets before completion truncation

7478abc

valerybugakov added the autocomplete label Jan 11, 2024

valerybugakov requested review from philipp-spiess and a team January 11, 2024 10:20

valerybugakov self-assigned this Jan 11, 2024

Autocomplete: add changelog entry

562dc8c

philipp-spiess approved these changes Jan 11, 2024

View reviewed changes

vscode/src/completions/get-inline-completions-tests/multiline-truncation.test.ts Outdated Show resolved Hide resolved

Autocomplete: update tests

57eab26

valerybugakov enabled auto-merge (squash) January 11, 2024 10:53

valerybugakov merged commit a9b8b05 into main Jan 11, 2024
16 checks passed

valerybugakov deleted the vb/artificial-brackets branch January 11, 2024 10:56