Edit/Chat: Change shortcut and add dedicated setting #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umpox
changed the title
|
I went with the wording "Command Hints" but open to better ideas, cc @abeatrix @toolmantim |
abeatrix
approved these changes
Jan 31, 2024
umpox
commented
Jan 31, 2024
Comment on lines
+839
to
+845
| "cody.commandHints.enabled": { | ||
| "order": 12, | ||
| "title": "Cody Command Hints", | ||
| "type": "boolean", | ||
| "markdownDescription": "Enable hints for Edit and Chat shortcuts, displayed alongside editor selections.", | ||
| "default": false | ||
| }, |
There was a problem hiding this comment.
This being more visible means users are going to start enabling it. I personally think we should enable it by default once we have the logic to show custom keyboard shortcuts if users try to change it
umpox
force-pushed
the
tr/cmd-chat-shortcuts
branch
from
02b406b
to
a99945f
Compare
umpox
added a commit
that referenced
this pull request
Feb 1, 2024
## Description These shortcuts were accidentally not enabled everywhere as part of #2865 We can enable these shortcuts fully now, even when the command hint setting is off ## Test plan 1. Check the `unstable` flag is off 2. Check shortcuts show normally <!-- Required. See https://sourcegraph.com/docs/dev/background-information/testing_principles. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Test plan