Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move context warnings from the UI to the debug log #2891

Merged

Conversation

toolmantim
Copy link
Contributor

@toolmantim toolmantim commented Jan 25, 2024

The context warnings in the UI are creating more confusion than they're worth, so we'll move them to the debug output and work on better ways of surfacing these issues as necessary in the transcript view.

Test plan

  • Recreate each warning scenario
  • Verify code behaves well

@toolmantim toolmantim marked this pull request as ready for review January 25, 2024 05:14
@toolmantim toolmantim requested a review from a team January 25, 2024 05:14
Copy link
Contributor

@dominiccooney dominiccooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for picking this up.

@toolmantim toolmantim merged commit e62ca32 into main Jan 25, 2024
14 checks passed
@toolmantim toolmantim deleted the tl/move-context-limits-from-transcript-to-debug-output branch January 25, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants