Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: display cody icon in chat panel title #2937

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Conversation

abeatrix
Copy link
Contributor

This commit updates the package.json for the VS Code extension by removing the condition that required the resourceScheme to be file for the cody.menu.commands to be visible in the editor title. This change allows the command to be visible regardless of the resource scheme, as long as cody.activated is true, config.cody.editorTitleCommandIcon is set, and the editor is not in readonly mode. This enhances the command's visibility and usability in various contexts within VS Code, and shows up in the chat panels.

Test plan

Before

cody icon doesn't show up in chat panel

image

After

image

@abeatrix abeatrix requested review from toolmantim and a team January 29, 2024 23:19
Copy link
Contributor

@toolmantim toolmantim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

In QA'ing this I did spot another bug where our chat icons seems to flash for a second in file buffers too:

CleanShot.2024-01-30.at.11.35.46.mp4

@abeatrix
Copy link
Contributor Author

Thanks!

In QA'ing this I did spot another bug where our chat icons seems to flash for a second in file buffers too:

CleanShot.2024-01-30.at.11.35.46.mp4

I looked into this, but I don't think this is something we have control over since vs code handles the when clauses 🤔

@abeatrix abeatrix merged commit dfcae84 into main Jan 31, 2024
14 checks passed
@abeatrix abeatrix deleted the bee/show-editor-title branch January 31, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants