Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove sparkle from context list without enhanced context #3006

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented Feb 1, 2024

Do not display sparkle emoji in Context list if no enhanced context was used, aka messages from the core commands.

/smell

image

/explain

image

Test plan

updated e2e tests to reflect this change.

@abeatrix abeatrix requested review from toolmantim and a team February 1, 2024 23:58
@abeatrix abeatrix changed the title Bee/remove sparkle fix: remove sparkle from context list without enhanced context Feb 1, 2024
Copy link
Contributor

@toolmantim toolmantim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@abeatrix abeatrix merged commit 119bed2 into bee/disable-edit-on-commands Feb 2, 2024
15 checks passed
@abeatrix abeatrix deleted the bee/remove-sparkle branch February 2, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants