feat: support @mention in mid message

[abeatrix]

CLOSE #2633

This PR includes changes to support @mention in mid message:

• Add context selection state and input caret tracking
• Add setContextSelection prop to allow parent to update context selection state
• Track inputCaretPosition in state to determine context selection based on caret position
• Store currentChatContextQuery to track context matching query
• Update context selection logic to use caret position rather than full input text
• Pass inputCaretPosition to ChatUITextArea
• Preserve text after caret when selecting context file
• Rename e2e tests for chat:
  • chat.test.ts -> chat-rateLimit.test.ts
  • at-file-context-selecting.test.ts -> chat-atFile.test.ts

Test plan

• Updated existing e2e tests
• Added a new test case for mid-sentence @-file to current e2e test

1. In the chat input box, type "Explain file to me"
2. Move your cursor behind 'Explain file'
3. Add a space behind 'Explain file'
4. Add '@'
5. You should see the file selection window show up

[toolmantim]

Woohoo. This is shaping up really nicely!!

Gave it a good test and noticed a few things, which I've tried to highlight in this video:

CleanShot.2024-02-07.at.15.04.22.mp4

• Accepting a suggestion should add a space
• Using left and right cursor should hide the suggestion popover
• After accepting a suggestion, hitting backspace and adding a character on the end shouldn't show "No matching files found" (see Slack's implementation for how we should probably handle it)
• Triggered some kind of race condition with editing (perhaps unrelated to this PR)

[abeatrix]

@toolmantim thanks for testing this out. Just updated the branch with the following changes, all covered by the updated e2e test as well

• Accepting a suggestion should add a space
• Using left and right cursor should hide the suggestion popover
• After accepting a suggestion, hitting backspace and adding a character on the end shouldn't show "No matching files found" (see Slack's implementation for how we should probably handle it)

[toolmantim]

Super close! It still shows "No matching files found" (and doesn't dismiss the popover when you send the message)

CleanShot.2024-02-07.at.22.54.14.mp4

vs

CleanShot.2024-02-07.at.23.01.03.mp4

[umpox]

Looks good! Only noticed one small thing:

It seems that the "No matching files found" message doesn't go away when using the arrow keys to go left or right

ChatMiddle@.mov

[abeatrix]

@toolmantim @umpox Thanks for testing the change so thoroughly! I've manually tested it and updated the tests. Please let me know if it is not working correctly for you.

Screen.Recording.2024-02-07.at.12.39.51.PM.mov

[toolmantim]

For me it still seems to lose the files when you edit the message:

CleanShot.2024-02-08.at.14.23.05.mp4

And the question mark case is showing "No matching files":

CleanShot.2024-02-08.at.14.24.09.mp4

[abeatrix]

For me it still seems to lose the files when you edit the message:

That's unrelated to this PR since this PR is for adding @-file in mid-sentence support. Will work on that in my next PR.

And the question mark case is showing "No matching files":

Thanks! I will update and make sure to add tests to cover this tomorrow. Surprise the current one doesn't 🫠

[toolmantim]

That's unrelated to this PR since this PR is for adding @-file in mid-sentence support. Will work on that in my next PR.

Ah, I didn't realise sorry! I didn't check main 👍🏼

[abeatrix]

That's unrelated to this PR since this PR is for adding @-file in mid-sentence support. Will work on that in my next PR.

Ah, I didn't realise sorry! I didn't check main 👍🏼

np! Just updated the PR with tests too. i think the test should cover all the expected behavior now?

For edits, it should work the same as press UP for history input right? I can look into that next 👍

[toolmantim]

🎉