Chat: Add tracing #3168
Chat: Add tracing #3168
Conversation
|
WOOOO |
| if (inputText.match(/^\/reset$/)) { | ||
| return this.clearAndRestartSession() | ||
| } | ||
| return tracer.startActiveSpan('chat.submit', async (span): Promise<void> => { |
There was a problem hiding this comment.
noob question: should we start the active span from when the question is submitted (from the command menu, chat view, or commands), or we only want to trace when we handle the request that was sent here?
If i want to add the tracing from when the command was executed, so we can trace how long it takes before it arrives to this function, do i just add another active span to that?
There was a problem hiding this comment.
Ideally as early as possible but when the trace is started it does not happen in the same JavaScript thread (it happens in the UI thread and not the extension host) so I put it here instead. Do you think there is a long delay until it arrives here?
There was a problem hiding this comment.
Do you think there is a long delay until it arrives here?
At least for commands, we fetch the context before they are sent here so it'd be cool to see those. I will add it to commands based off your branch and try it out!
There was a problem hiding this comment.
Ah, yeah for the simple chat provider I think this function is called pretty much immediately after the webview message arrives. Context fetching happens later
Context: https://sourcegraph.slack.com/archives/C05AGQYD528/p1707924889951959 Based off #3168 Add tracing to Command and Custom Command on execution time. ## Test plan <!-- Required. See https://sourcegraph.com/docs/dev/background-information/testing_principles. --> Add tracing. Tracing for explain command:  Tracing for smell command:  Tracing for doc command:  Tracing for test command:  Tracing for custom command:  --------- Co-authored-by: Philipp Spiess <hello@philippspiess.com>
As the title suggests. Please review with whitespace changes hidden.
Test plan
e.g.: https://ui.honeycomb.io/sourcegraph/environments/cody/datasets/cody-client/result/oy1kwHxdSmP/trace/9xmczeHgPAu?fields[]=s_name&fields[]=s_serviceName&span=6dc03ea5de6419ae