Chat: Display file range correctly #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeatrix
commented
Feb 14, 2024
| await expect( | ||
| chatPanel.getByRole('button', { name: withPlatformSlashes('@lib/batches/env/var.go:1-0') }) |
There was a problem hiding this comment.
this shows the line numbers were not handled correctly.
kalanchan
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSE: #3110
Updated code to display document range correctly in chat view.
This commit updates the code to correctly handle the selection range.
Test plan
All changes are covered by the updated e2e tests.
After
1-15 is used and shows up as 1-15
clicking on 1-15 highlights 1-15 in the document
Before
1-15 is used but showing up as 1-13
clicking one 1-13 link highlights 1-14 in the document
