Chat: support line numbers in at-files

[abeatrix]

feat: enable users to add line number to @-file queries

Key changes:

• Extract input parsing logic into new inputParser.ts file. The module parses line numbers after file names in the input string. It sets the parsed range on the context file objects.
• Remove separate display text generation logic for selections. Instead always pass file range to create markdown links. This allows links to point directly to user-provided line number context when available.
• Covered by unit tests.

These changes enable users to add line number context to their @-mentioned queries by appending ':line-range' after file names. The line range will be parsed and used to generate more precise code links.

Test plan

Screen.Recording.2024-02-14.at.2.59.31.PM.mov

After

Loom: https://www.loom.com/share/28cadce2a91f4e5892d3ee3a7b6f82dc

On Edit:

Screen.Recording.2024-02-20.at.12.05.51.PM.mov

Before

Next

Implement this with the default chat commands.

[toolmantim]

Nice! This gets us the building block we need for making commands explicitly show the selected lines.

A few bugs:

• It seems to break if you click on items in the popover, vs hitting enter with the keyboard
• If you use the up arrow to load the last message input doesn't seem to attach @-mentioned files either.

To make the experience for manually typing it in better… it would be good to not have the popover disappear, as it makes it feel like it's not going to work. Can we keep it open, and show some 50% opacity helper text as they type?

CleanShot.2024-02-15.at.21.52.42@2x.mp4

[abeatrix]

@toolmantim I can't reproduce the first issue you mentioned. Can you try the latest commit and see if it's still broken for you?

Screen.Recording.2024-02-15.at.8.35.21.AM.mov

• [] It seems to break if you click on items in the popover, vs hitting enter with the keyboard
• If you use the up arrow to load the last message input doesn't seem to attach @-mentioned files either.
• Added the helper:

[abeatrix]

@toolmantim I've updated the PR to support single line range:

Screen.Recording.2024-02-20.at.12.05.51.PM.mov

We can merge this after tomorrow release if we want to polish this more

[toolmantim]

👏🏼