Update the logged out status bar item with more obvious CTA

[toolmantim]

Updates the Cody status bar button to have the text "Sign in to Cody" when not logged in.

PRD

Asana task

Before:

CleanShot.2024-02-21.at.11.43.34.mp4

After:

CleanShot.2024-03-15.at.23.45.55.mp4

Events added:

• CodyVSCodeExtension:signInNotification:shown
• CodyVSCodeExtension:signInNotification:signIn:clicked
• CodyVSCodeExtension:signInNotification:doNotShow:clicked
• CodyVSCodeExtension:statusBarIcon:clicked, { loggedIn: boolean }

Test plan

• CI
• Test logged out & logging in
• Test logged in

[toolmantim]

This doesn't update the setup notification, but it uses different language that we should probably also update:

[chenkc805]

Thanks Tim! Not sure if this is in progress, but just so we don't miss it:

• Can we update the copy in the popup? "Setup" isn't quite the right call to action. LMK if this is in a separate PR
• Is there a way to have the status bar icon open up the sidebar instead of the quickpick if you're not logged in? Gets rid of the user having to see the quickpick, thus removing a step.

[toolmantim]

Yep we can update the copy, and I can make it just focus the sidebar.

It does mean the settings quickpick items (links to support/docs) will only be accessible if you’re logged in. I think that’s fine, but just wanted to call it out.

[chenkc805]

It does mean the settings quickpick items (links to support/docs) will only be accessible if you’re logged in. I think that’s fine, but just wanted to call it out.

Yes that's right. Most of the information here is only relevant to logged in users, and if users want to look for docs they can go to Google.

[toolmantim]

This PR is ready to go.

@kelsey-brown the final events we ended up logging are slightly different to the Google Doc:

• CodyVSCodeExtension:signInNotification:shown
• CodyVSCodeExtension:signInNotification:signIn:clicked
• CodyVSCodeExtension:signInNotification:doNotShow:clicked
• CodyVSCodeExtension:statusBarIcon:clicked, { loggedIn: boolean }

Are these okay? In particular I'm wondering if the loggedIn properly on statusBarIcon clicked can be used to identify people clicking the status bar when loggedIn == false.

[kelsey-brown]

@toolmantim is CodyVSCodeExtension:signInNotification:shown the enrollment event then?

In particular I'm wondering if the loggedIn properly on statusBarIcon clicked can be used to identify people clicking the status bar when loggedIn == false.

Yes, if this is logged with the metadata on the event we can filter/pivot clicks by loggedIn = true / loggedIn = false

[toolmantim]

Thanks @kelsey-brown. Yep, that should work as the enrollment event. Though this isn't running as an experiment in the code at all (I've never done that before)

[sqs]

For the actual text, how about: “(icon) Sign In”? That seems best. Shortest and least words.

I hate long and advertisingy status bar items. Other competitors (won’t name in public) do this and it looks very spammy. This is not spammy but I want to really be careful to have a super short message down here.

[toolmantim]

@sqs I didn't want to confuse it with a Microsoft/GH login button. Are you thinking it's a bad experience for the person that just installed it, or for the person that keeps it installed but doesn't login and wants to ignore it for now (and we don't want them to uninstall)?

[sqs]

@sqs I didn't want to confuse it with a Microsoft/GH login button. Are you thinking it's a bad experience for the person that just installed it, or for the person that keeps it installed but doesn't login and wants to ignore it for now (and we don't want them to uninstall)?

Both. And I just have a negative reaction to anything that takes up a lot of space in my status bar. Can you check with a few other devs on the team for their kneejerk reaction? If I'm the only one, then feel free to disregard.

[toolmantim]

First impressions matter! Will straw poll.

[toolmantim]

I've updated the label to be "Sign In" so we can unblock this and get it out