-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Command: supports keybinding registration #3242
Conversation
“register” is a very generic property name, which could mean anything. Perhaps “allowKeybinding” is more suitable? Also does this property make sense for Jetbrains, or is it very VS Code specific? Instead… why don’t we just register all custom commands by default? |
Jetbrains supports custom keymap as well so i'd assume yes? It will not break Jetbrains as well since the
I thought about registering all custom commands but i'm not sure if that'd be a good idea for users that have 1000 custom commands. |
Do we support 1000 custom commands? I think that is beyond our design specs. I'd suggest we register them by default and do away with the config — it's one less config to document, discover, etc. |
Makes sense, will update the PR tomorrow to reflect this! |
CLOSE #3202
Keyboard Shortcuts editor
This allows custom commands to be executed via custom keybindings in VS Code.
Also added related docs and walkthrough page.
Test plan
Keyboard Shortcuts
editorKeyboard Shortcuts
editor, search forcody.command.customn.{NAME_OF_YOUR_COMMAND}
+
icon next to the command to assign a custom keybinding for your custom command