Edit: Fix missing context for instruction-based inputs #3309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@philipp-spiess noticed that Edit was not including context, which it should have been doing.
Recent work around commands + context improvements introduced a couple of bugs that weren't obvious:
contextMessages
are defaulted to[]
from the Edit input, we had a bad check for theserange
is an optional value forContextItem
, but we rely on it to generate unique IDs for content within a file. This adds an extra ID mechanism to uniquely hash thecontent
of the item alongside the file URI (if available)Test plan