-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat: Shows welcome message on empty chat only #3341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gooo!
The original intention of the linked issue was that if you start a new chat you don’t get the welcome message. Did we try that and it didn’t feel right, or? |
That's the behavior in this PR, isn't it? You don't see a welcome message after you have started a new chat? Or did I misinterpret the issue lol? |
I don’t love it just disappearing. If we feel it’s too blank to simply exclude any welcome message, we can instead have a more minimal welcome message for chats that aren’t the very first one. |
Ah! So the original issues was meant to be:
|
Some clarify questions: By chat are you referring to chat message, or chat panel?
Don't show the welcome message forever? |
Whole chats (chat panels)
Yep, only on the first chat they ever create. We can try it out in a PR and see how it feels, and if it feels too bare maybe we need a more minimal chat welcome message for chats after the first one. |
In #3341 the behavior changed so that the welcome message goes away when you chat. (Which I love!) But there's a minor bug in that the model selector remains enabled after the 1st message is sent now (because the existing logic assumed that the welcome message was always the 1st message and so checked for `>1` messages to disable the model selector).
Love this change! Feels so much cleaner. Found and fixed a minor bug: #3354. |
CLOSE #2461
This PR removes the welcome message after the first question has been submitted.
Test plan
Before