Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat: Shows welcome message on empty chat only #3341

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented Mar 7, 2024

CLOSE #2461

image

This PR removes the welcome message after the first question has been submitted.

Test plan

  1. Open a new chat to confirm welcome message is displayed
  2. Submit a question / execute a command
  3. the welcome message should disappear

Before

image

Copy link
Contributor

@kalanchan kalanchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gooo!

@abeatrix abeatrix merged commit 2207176 into main Mar 7, 2024
16 checks passed
@abeatrix abeatrix deleted the bee/remove-welcome branch March 7, 2024 22:16
@toolmantim
Copy link
Contributor

The original intention of the linked issue was that if you start a new chat you don’t get the welcome message. Did we try that and it didn’t feel right, or?

@abeatrix
Copy link
Contributor Author

abeatrix commented Mar 7, 2024

That's the behavior in this PR, isn't it? You don't see a welcome message after you have started a new chat? Or did I misinterpret the issue lol?

@toolmantim
Copy link
Contributor

I don’t love it just disappearing. If we feel it’s too blank to simply exclude any welcome message, we can instead have a more minimal welcome message for chats that aren’t the very first one.

@toolmantim
Copy link
Contributor

Ah! So the original issues was meant to be:

  • On your first chat, it has the welcome message
  • Any additional chats you start don’t show the welcome message at all

@abeatrix
Copy link
Contributor Author

abeatrix commented Mar 7, 2024

Some clarify questions:

By chat are you referring to chat message, or chat panel?

  • Any additional chats you start don’t show the welcome message at all

Don't show the welcome message forever?

@toolmantim
Copy link
Contributor

By chat are you referring to chat message, or chat panel?

Whole chats (chat panels)

Don't show the welcome message forever?

Yep, only on the first chat they ever create.

We can try it out in a PR and see how it feels, and if it feels too bare maybe we need a more minimal chat welcome message for chats after the first one.

sqs added a commit that referenced this pull request Mar 8, 2024
In #3341 the behavior changed so that the welcome message goes away when you chat. (Which I love!) But there's a minor bug in that the model selector remains enabled after the 1st message is sent now (because the existing logic assumed that the welcome message was always the 1st message and so checked for `>1` messages to disable the model selector).
@sqs
Copy link
Member

sqs commented Mar 8, 2024

Love this change! Feels so much cleaner. Found and fixed a minor bug: #3354.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Cody chat welcome message when a new chat has been triggered by a command
4 participants