Autocomplete: upgrade tree-sitter and expand language support #3373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umpox
approved these changes
Mar 11, 2024
Comment on lines
+67
to
+69
| // stop parsing after 50ms to avoid infinite loops | ||
| // if that happens, tree-sitter throws an error so we can catch and address it | ||
| parser.setTimeoutMicros(50_000) |
There was a problem hiding this comment.
Do we log the error anywhere? It'd be useful to know how often this times out in prod
There was a problem hiding this comment.
Our Sentry setup should pick it up on prod.
Comment on lines
+158
to
+162
| (interface_body | ||
| (property_signature | ||
| name: (property_identifier) @signature.property))) | ||
| (interface_declaration | ||
| (object_type | ||
| (interface_body |
There was a problem hiding this comment.
Thank you for upgrading! I noticed this difference when trying to copy a query from the playground, definitely something we'll have to be proactive about but great that we have tests for these queries :)
I've been adding new queries in #3275 so I'll rebase that onto this
philipp-spiess
approved these changes
Mar 11, 2024
vscode/src/completions/get-inline-completions-tests/post-processing.test.ts
Show resolved
Hide resolved
Co-authored-by: Tom Ross <tom@umpox.com>
steveyegge
pushed a commit
that referenced
this pull request
Mar 13, 2024
- Upgrade tree-sitter from `0.20.8` to `0.21.0` and update the code based on breaking changes. - Migrate from custom S3-hosted grammars to the latest grammars from `npm` via [tree-sitter-wasms](https://github.com/Gregoor/tree-sitter-wasms). This expands the tree-sitter language support and improves grammars error tolerance. - Follow-up issue #3374 - Add timeout to the tree-sitter parse method to avoid freezing users' editor instances in case of unexpected errors. - Refactor how tree-sitter edits are calculated to paste completions into the existing document. This fixes the issue described in [the Slack thread](https://sourcegraph.slack.com/archives/C05AGQYD528/p1709892644622649?thread_ts=1709891165.036869&cid=C05AGQYD528). - Updated the `SupportedLanguage` enum to keep all keys and values equal to the possible `document.languageId` values.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
0.20.8to0.21.0and update the code based on breaking changes.npmvia tree-sitter-wasms. This expands the tree-sitter language support and improves grammars error tolerance.dartsupport #3374SupportedLanguageenum to keep all keys and values equal to the possibledocument.languageIdvalues.Test plan