Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete: do not cut off completions #3377

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Autocomplete: do not cut off completions #3377

merged 2 commits into from
Mar 11, 2024

Conversation

valerybugakov
Copy link
Member

@valerybugakov valerybugakov commented Mar 11, 2024 •
edited
Loading

Context

  • I often bump into cases where I expect the completion, but it's not shown because the following line is almost identical. This PR replaces this check with the strict equality one.
  • Adds a changelog entry for my previous PR.

Test plan

CI

@valerybugakov valerybugakov self-assigned this Mar 11, 2024
@valerybugakov valerybugakov requested review from philipp-spiess and a team March 11, 2024 12:23
@valerybugakov valerybugakov marked this pull request as ready for review March 11, 2024 12:23
@valerybugakov valerybugakov enabled auto-merge (squash) March 11, 2024 12:27
@valerybugakov valerybugakov merged commit 0d197d7 into main Mar 11, 2024
15 of 16 checks passed
@valerybugakov valerybugakov deleted the vb/trim-until-suffix-update branch March 11, 2024 12:34
steveyegge pushed a commit that referenced this pull request Mar 13, 2024
@valerybugakov @steveyegge
Autocomplete: do not cut off completions (#3377)
88de1c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp-spiess philipp-spiess philipp-spiess approved these changes

Assignees

@valerybugakov valerybugakov

Labels
autocomplete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@valerybugakov @philipp-spiess