prevent Cody from crashing on init with mis-serialized chat history #3394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to #3367, this prevents Cody from crashing on initialization if the chat history contains `vscode.Range` JSON-serialized values (which are JSON-serialized as `[start, end]`). This is an easy and subtle bug to introduce, and it's valuable to protect against complete crashing on initialization. The stack trace of the crash that this prevents is: ``` TypeError: Cannot read properties of undefined (reading 'line') at createDisplayTextWithFileLinks (/home/sqs/.vscode/extensions/sourcegraph.cody-ai-1.8.2/dist/extension.node.js:124081:56) at getDisplayText (/home/sqs/.vscode/extensions/sourcegraph.cody-ai-1.8.2/dist/extension.node.js:124292:12) at prepareChatMessage (/home/sqs/.vscode/extensions/sourcegraph.cody-ai-1.8.2/dist/extension.node.js:124279:18) at groupCodyChats (/home/sqs/.vscode/extensions/sourcegraph.cody-ai-1.8.2/dist/extension.node.js:124336:26) ... ```
philipp-spiess
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #3367, this prevents Cody from crashing on initialization if the chat history contains
vscode.RangeJSON-serialized values (which are JSON-serialized as[start, end]). This is an easy and subtle bug to introduce, and it's valuable to protect against complete crashing on initialization.The stack trace of the crash that this prevents is:
I will backport this to the v1.8.0 branch to ensure that users can switch back to the release version safely if they were on the prerelease version (which has mis-serialized chat history at certain times).
Test plan
CI