Edit: Only compute diffs for actual edits #3424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently try to compute the diff for all Edits, regardless if they are editing existing code or inserting new code.
Trying to produce a diff for
inserting
code is weird, because we actually don't care about the users' selection, but we still use it to compute the diff.This can lead to a very misleading animation as the Edit computes, and it's also inefficient as we just throw the diff away anyway
Test plan