Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix log spam in e2e flakiness detector #3450

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix log spam in e2e flakiness detector #3450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/e2e-flakiness-detector.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,12 @@ jobs:
- run: pnpm install
- run: xvfb-run -a pnpm -C vscode run test:e2e --repeat-each 10 --retries 0
if: matrix.runner == 'ubuntu'
env:
NO_LOG_TESTING_TELEMETRY_CALLS: "1"
- run: pnpm -C vscode run test:e2e --repeat-each 10 --retries 0
if: matrix.runner != 'ubuntu'
env:
NO_LOG_TESTING_TELEMETRY_CALLS: "1"
- uses: actions/upload-artifact@v3
if: ${{ failure() }}
with:
Expand Down
11 changes: 3 additions & 8 deletions vscode/test/fixtures/mock-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,16 +57,11 @@ const pubSubClient = new PubSub({
projectId: 'sourcegraph-telligent-testing',
})

const publishOptions = {
const topicPublisher = pubSubClient.topic('projects/sourcegraph-telligent-testing/topics/e2e-testing', {
gaxOpts: {
timeout: 120000,
},
}

const topicPublisher = pubSubClient.topic(
'projects/sourcegraph-telligent-testing/topics/e2e-testing',
publishOptions
)
})

//#region GraphQL Mocks

Expand Down Expand Up @@ -480,7 +475,7 @@ export class MockServer {
const loggedTestRun: Record<string, boolean> = {}

async function logTestingData(type: 'legacy' | 'new', data: string): Promise<void> {
if (process.env.CI === undefined) {
if (process.env.CI === undefined || process.env.NO_LOG_TESTING_TELEMETRY_CALLS) {
return
}

Expand Down
Loading