-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat: Display Enhanced Context settings on first chat #3547
Conversation
@toolmantim before I fix the e2e tests to reflect the new behavior, can you take a look and let me know if this aligns with what you had in mind? |
@abeatrix Nice! Yeah checking it out now. Quick one: I spotted |
added a new event |
Just pushed a bunch of style fixes, and the only thing left I think is some of the keyboard accessibility fixes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock, given how close this is
Thank you so much for your help with the css ❤️ I'll work on the keyboard shortcuts tomorrow, and then update all the outdated e2e tests and add new ones to cover these new behavior. Thanks again! |
|
presentationMode={userInfo.isDotComUser ? 'consumer' : 'enterprise'} | ||
isFirstChat={transcript.length < 1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only spotted this logic. This is more like isEmptyChat
which isn't what we want here. We want it to appear on the first chat that's created for first time users, not every time a chat is created.
CLOSE #2839
Test plan
To test this manually:
After
First chat for Dot Com users:
First chat for enterprise users: