Chat: update @-input token background #3548
Merged
+1
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed the color background and added a border radius: CleanShot.2024-03-26.at.21.11.13.mp4I really wish we could add some padding, but every time I tried it didn't quite work. This PR also has the side effect of changing the cursor color when you're in a token — ideally we select the token when you click on it or move the cursor into it, similar to how https://github.com/sodenn/lexical-beautiful-mentions works. I wonder if there's some code/tricks in lexical-beautiful-mentions we could use so we can render and interact with these more nicely? |
toolmantim
approved these changes
Mar 26, 2024
valerybugakov
pushed a commit
that referenced
this pull request
Apr 22, 2024
Co-authored-by: Tim Lucas <t@toolmantim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue from #3501 (comment)
Remove
.context-item-mention-node::beforethat sets background color with opacity, setbackground-colortorgba(200, 200, 200, 0.2);to add blurred background instead.Test plan
Before
After