Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cody Ignore: remove git CLI repo-name resolver #4132

Merged
merged 3 commits into from
May 10, 2024
Merged

Cody Ignore: remove git CLI repo-name resolver #4132

merged 3 commits into from
May 10, 2024

Conversation

valerybugakov
Copy link
Member

  • Removes the git CLI repo-name resolver because it performs worse than other existing alternatives (VS Code Git extension and file system tree-walk). There are no cases where it is preferred over alternatives, so we can simplify the codebase by deleting it.

Test plan

CI

@valerybugakov valerybugakov requested review from dominiccooney and a team May 10, 2024 07:12
@valerybugakov valerybugakov self-assigned this May 10, 2024
@valerybugakov valerybugakov enabled auto-merge (squash) May 10, 2024 07:32
valerybugakov
valerybugakov commented May 10, 2024
View reviewed changes
lib/shared/src/sourcegraph-api/graphql/queries.ts
@@ -103,7 +103,6 @@ query Repositories($first: Int!, $after: String) {
nodes {
id
name
url
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused response field.

@valerybugakov valerybugakov merged commit e01888c into main May 10, 2024
18 of 19 checks passed
@valerybugakov valerybugakov deleted the vb/remove-git-cli-resolver branch May 10, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp-spiess philipp-spiess philipp-spiess approved these changes

@dominiccooney dominiccooney Awaiting requested review from dominiccooney

Assignees

@valerybugakov valerybugakov

Labels
cody enterprise pfp-jetbrains-cody-ignore pfp-vscode-cody-ignore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@valerybugakov @philipp-spiess