fix: chat history command and remove setTab #414
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current the
![image](https://private-user-images.githubusercontent.com/68532117/256578624-2a9e94a1-7454-4aca-a537-6c7c43d0de19.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2MjIxMDUsIm5iZiI6MTcyMTYyMTgwNSwicGF0aCI6Ii82ODUzMjExNy8yNTY1Nzg2MjQtMmE5ZTk0YTEtNzQ1NC00YWNhLWE1MzctNmM3YzQzZDBkZTE5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIyVDA0MTY0NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA5ZjM4M2RhNTkyODg2N2YxYjczY2RhMjZjODJjYzI1YzYyYTZkZjE5NmY5MzM1YmM4ZTViZGMyNzljODEyNWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.rUCSnP_F3ok4q9EaQQ0WhiZubu85LYyuIWYJD_nUqB0)
Chat History
command does not show you the Chat History view:This is because chat history command was using showTab('history') is doing the same thing as the
setWebviewView(view)
but only acceptschat
as the view, which is confusing and redundant.TIncluded in this PR:
showTab
and move tosetWebviewView
isTextTooShort
to helper function (context)Test plan
locally tested and all the tests are still passing after the change